Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeDocumentNode support (2nd attempt) #153

Merged
merged 18 commits into from
Jan 20, 2025
Merged

TypeDocumentNode support (2nd attempt) #153

merged 18 commits into from
Jan 20, 2025

Conversation

IzumiSy
Copy link
Member

@IzumiSy IzumiSy commented Jan 20, 2025 •
edited
Loading

The PR for #103

data

スクリーンショット 2025-01-20 20 52 07

variables

スクリーンショット 2025-01-20 21 11 22

getComponent

Only the name of the root selection is specifiable.

スクリーンショット 2025-01-20 20 54 57

@IzumiSy IzumiSy self-assigned this Jan 20, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: af8e0c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@fabrix-framework/fabrix Minor
@fabrix-framework/chakra-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 20, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/chakra-ui@153

npm i https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/fabrix@153

npm i https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/graphql-config@153

commit: b857a07

@IzumiSy IzumiSy marked this pull request as ready for review January 20, 2025 12:33
@IzumiSy IzumiSy requested a review from a team as a code owner January 20, 2025 12:33
Base automatically changed from remove_get_operation_function to main January 20, 2025 12:42
toiroakr
toiroakr previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@toiroakr toiroakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@IzumiSy IzumiSy dismissed toiroakr’s stale review January 20, 2025 12:45

The merge-base changed after approval.

@IzumiSy IzumiSy requested a review from toiroakr January 20, 2025 12:45
@IzumiSy
Copy link
Member Author

IzumiSy commented Jan 20, 2025

@toiroakr sorry, I had to resolve merge conflicts that dismissed your approve 🙏

Can you approve this PR again?

@IzumiSy IzumiSy merged commit 7c104b0 into main Jan 20, 2025
@IzumiSy IzumiSy deleted the type_document_node_support branch January 20, 2025 13:23
This was referenced Jan 20, 2025
Merged
Open
@IzumiSy IzumiSy mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toiroakr toiroakr toiroakr approved these changes

Assignees

@IzumiSy IzumiSy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IzumiSy @toiroakr